[change] Remove tracking from series plugin#3679
Merged
gazpachoking merged 8 commits intodevelopfrom Aug 17, 2023
Merged
Conversation
Member
Author
|
I'm running this for a while locally before merging |
Member
|
I'm good with it 👍 |
| and update the version again for continued development. | ||
| """ | ||
| __version__ = '3.8.8.dev' | ||
| __version__ = '3.9.dev' |
Contributor
There was a problem hiding this comment.
3.9 is invalid on semver that broke the web interface.
This is from the browser console:
TypeError: Invalid Version: 3.9
l semver.js:41
exports compare.js:3
exports gt.js:2
Ot Version.tsx:25
React 7
unstable_runWithPriority scheduler.production.min.js:18
React 5
e hooks.tsx:10
u runtime.js:45
_invoke runtime.js:271
t runtime.js:97
bt main.cce4d52f6988bfadab4f.js:1
i main.cce4d52f6988bfadab4f.js:1
promise callback*bt main.cce4d52f6988bfadab4f.js:1
i main.cce4d52f6988bfadab4f.js:1
e main.cce4d52f6988bfadab4f.js:1
e main.cce4d52f6988bfadab4f.js:1
yt hooks.tsx:7
yt hooks.tsx:13
React 2
unstable_runWithPriority scheduler.production.min.js:18
React 4
unstable_runWithPriority scheduler.production.min.js:18
React 5
e Login.tsx:17
u runtime.js:45
_invoke runtime.js:271
t runtime.js:97
$ 14.18cf3ab07df2cff9c980.js:1
i 14.18cf3ab07df2cff9c980.js:1
promise callback*$ 14.18cf3ab07df2cff9c980.js:1
i 14.18cf3ab07df2cff9c980.js:1
e 14.18cf3ab07df2cff9c980.js:1
e 14.18cf3ab07df2cff9c980.js:1
default Login.tsx:14
default Login.tsx:20
React 2
unstable_runWithPriority scheduler.production.min.js:18
React 4
unstable_runWithPriority scheduler.production.min.js:18
React 2
V scheduler.production.min.js:17
onmessage scheduler.production.min.js:14
EventHandlerNonNull* scheduler.production.min.js:13
Webpack 14
Member
There was a problem hiding this comment.
I just added a note in our version file so that we hopefully remember next time. A new release will come out tomorrow and fix the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Tracking previously as is made it impossible to discover sequence based episodes since searching 1 resulted episodes 10, 11, etc accepted. Then episode 2 was rejected because being too much in the past.
Detailed changes:
The tracking is replaced by relying on begin which can be set from CLI and via plugins. This should work better overall. Fixed couple probably bugs while at it.