[Fix] magnetdl error 404 when search string contains a special character#3644
Merged
paranoidi merged 2 commits intoFlexget:developfrom Dec 27, 2022
Merged
[Fix] magnetdl error 404 when search string contains a special character#3644paranoidi merged 2 commits intoFlexget:developfrom
paranoidi merged 2 commits intoFlexget:developfrom
Conversation
Member
|
thanks! |
|
I'm getting "name 'unicodedata' is not defined" errors. I think there's a missing |
Contributor
Author
|
good catch, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
magnetdl search returns error 404 every time the search term contains a special character because magnetdl.com search path can only contains [a-z0-9] and slashes/-. Current implementation is not good enough.
Detailed changes:
Log and/or tests output (preferably both):
Magnetdl.com should return 200 even when there is no matches but it returns error 404 due to malform URLs