Add series pack support for guessit parser#3548
Merged
Conversation
ghost
commented
Oct 5, 2022
| if not self._is_valid_groups(group, guessit_options.get('allow_groups', [])): | ||
| valid = False | ||
| # Validate country, TODO: LEGACY | ||
| if country and name.endswith(')'): |
Author
There was a problem hiding this comment.
this was changing to valid = False valid cases like Dark because this assume that anything inside of () after the show name is the country, so changed to use guessit that parse the country in a better way, also guessit convert UK to GB so entry Show (UK) will be parse to { title: 'Show', country: 'GB' } and if the user show is Show (UK) will be marked as invalid because this did gb != uk, so using parsing will be parsed in the same way
for more information, see https://pre-commit.ci
Member
|
Hey, awesome work. High quality PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Series plugin support season pack for
identify_by epand Internal parsing have partial support even guessit more capabilities and support season packs in more cases than internal guessit, so this PR add support of pack for guessit in flexgetDetailed changes:
Dark (2022)Addressed issues:
Implemented feature requests:
Config usage if relevant (new plugin or updated schema):
Log and/or tests output (preferably both):