Skip to content

Add series pack support for guessit parser#3548

Merged
paranoidi merged 2 commits intodevelopfrom
unknown repository
Oct 23, 2022
Merged

Add series pack support for guessit parser#3548
paranoidi merged 2 commits intodevelopfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 5, 2022

Motivation for changes:

Series plugin support season pack for identify_by ep and Internal parsing have partial support even guessit more capabilities and support season packs in more cases than internal guessit, so this PR add support of pack for guessit in flexget

Detailed changes:

  • Update guessit parser to support series pack
  • Fix check by country that was rejecting valid cases like Dark (2022)

Addressed issues:

  • N/A

Implemented feature requests:

  • N/A

Config usage if relevant (new plugin or updated schema):

    discover:
      what:
        - next_series_seasons:
            from_start: yes
            backfill: yes
      from:
        - 1337x:
            order_by: seeders
    configure_series:
      from:
        entry_list: watchlist_series
      settings:
        identified_by: ep
        tracking: backfill
        exact: yes
        season_packs: only

Log and/or tests output (preferably both):

paste output here

if not self._is_valid_groups(group, guessit_options.get('allow_groups', [])):
valid = False
# Validate country, TODO: LEGACY
if country and name.endswith(')'):
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was changing to valid = False valid cases like Dark because this assume that anything inside of () after the show name is the country, so changed to use guessit that parse the country in a better way, also guessit convert UK to GB so entry Show (UK) will be parse to { title: 'Show', country: 'GB' } and if the user show is Show (UK) will be marked as invalid because this did gb != uk, so using parsing will be parsed in the same way

@paranoidi paranoidi merged commit 1086578 into Flexget:develop Oct 23, 2022
@paranoidi
Copy link
Copy Markdown
Member

Hey, awesome work. High quality PR :)

@ghost ghost deleted the feat-guessit-series-pack-support branch October 23, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant