Skip to content

added ncore site#3468

Merged
paranoidi merged 13 commits intoFlexget:developfrom
DDanii:develop
Jul 1, 2022
Merged

added ncore site#3468
paranoidi merged 13 commits intoFlexget:developfrom
DDanii:develop

Conversation

@DDanii
Copy link
Copy Markdown
Contributor

@DDanii DDanii commented Jun 6, 2022 •
edited
Loading

Config usage if relevant (new plugin or updated schema):

ncore:
  username: 'username'
  password: 'password'
  category: ['hd_hun', 'xvid_hun'] #optional
  sort_by: 'size' #optional
  sort_reverse: true #optional

Log and/or tests output (preferably both):

2022-06-06 22:30:24 VERBOSE  discover      movies search   Discovering 6 titles ...
2022-06-06 22:30:24 INFO     discover      movies search   Ignoring interval because of --discover-now
2022-06-06 22:30:24 VERBOSE  discover      movies search   Searching for `Spider-Man: No Way Home (2021)` with plugin `ncore` (1 of 6)
2022-06-06 22:30:25 VERBOSE  discover      movies search   Searching for `Inception (2010)` with plugin `ncore` (2 of 6)
2022-06-06 22:30:26 VERBOSE  discover      movies search   Searching for `The Lost City (2022)` with plugin `ncore` (3 of 6)
2022-06-06 22:30:27 VERBOSE  discover      movies search   Searching for `Fantastic Beasts: The Secrets of Dumbledore (2022)` with plugin `ncore` (4 of 6)
2022-06-06 22:30:28 VERBOSE  discover      movies search   Searching for `Sonic the Hedgehog 2 (2022)` with plugin `ncore` (5 of 6)
2022-06-06 22:30:29 VERBOSE  discover      movies search   Searching for `The Matrix (1999)` with plugin `ncore` (6 of 6)
2022-06-06 22:30:30 VERBOSE  details       movies search   Produced 70 entries.

To Do:

@BrutuZ
Copy link
Copy Markdown
Contributor

BrutuZ commented Jun 6, 2022

Forwarding a couple comments I received on previous contributions:

  • Any particular reason to have the requests data formatted as a string instead of a dict?
  • Could turn the plugin into a generator (use yield inside of the loop instead of return after) to make it compatible with the limit plugin.

@DDanii
Copy link
Copy Markdown
Contributor Author

DDanii commented Jun 7, 2022 •
edited
Loading

Thanks for the comments.

  • That is the format the browser sent to the site. I'm not sure how I would generate that from a dict.
  • Changed it to yield.

@BrutuZ
Copy link
Copy Markdown
Contributor

BrutuZ commented Jun 7, 2022

I'm not sure how I would generate that from a dict

You don't have to, Requests accepts dicts for data and handles them accordingly

@DDanii
Copy link
Copy Markdown
Contributor Author

DDanii commented Jun 7, 2022

Thanks for the heads up

paranoidi
paranoidi reviewed Jun 8, 2022
View reviewed changes
@DDanii
Copy link
Copy Markdown
Contributor Author

DDanii commented Jun 29, 2022

@paranoidi It is good now?

@paranoidi paranoidi merged commit aae0e9d into Flexget:develop Jul 1, 2022
@paranoidi
Copy link
Copy Markdown
Member

paranoidi commented Jul 1, 2022

Yep, thanks, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paranoidi paranoidi paranoidi left review comments

+1 more reviewer

@BrutuZ BrutuZ BrutuZ left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DDanii @BrutuZ @paranoidi