Skip to content

[add] qbittorrent: Pass tag(s) when adding torrents to client#3271

Merged
gazpachoking merged 7 commits intoFlexget:developfrom
whiteout12:qbt-tags
Dec 15, 2021
Merged

[add] qbittorrent: Pass tag(s) when adding torrents to client#3271
gazpachoking merged 7 commits intoFlexget:developfrom
whiteout12:qbt-tags

Conversation

@whiteout12
Copy link
Copy Markdown
Contributor

@whiteout12 whiteout12 commented Dec 6, 2021

Motivation for changes:

Qbittorrent has a tag feature which is not yet supported by Flexget's qbittorrent-plugin.

Detailed changes:

  • Added Tags to be passed by Qbittorrent-plugin to Qbittorrent.
  • Renders entry specific tags as well as static tags from config.

Config usage if relevant (new plugin or updated schema):

Optional config if tags are to be used.

templates:
  qbt:
    qbittorrent:
      tags:
        - Flexget
tasks
  Testtask:
    template:
      - qbt
    set:
      tags:
        - '{{quality.resolution}}'
        - Test

Log and/or tests output (preferably both):

2021-12-06 21:30:05 INFO     qbittorrent   test-qbt        Would add torrent to qBittorrent with:
2021-12-06 21:30:05 INFO     qbittorrent   test-qbt        File: None
2021-12-06 21:30:05 INFO     qbittorrent   test-qbt        Label: None
2021-12-06 21:30:05 INFO     qbittorrent   test-qbt        Tags: Flexget,1080p
2021-12-06 21:30:05 INFO     qbittorrent   test-qbt        Paused: true

gazpachoking
gazpachoking requested changes Dec 7, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@gazpachoking gazpachoking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me! I left a few comments in there.

whiteout12 and others added 2 commits December 7, 2021 18:59
@whiteout12 @gazpachoking
Update flexget/plugins/clients/qbittorrent.py
cda98fa 
Co-authored-by: Chase Sterling <chase.sterling@gmail.com>
@whiteout12 @gazpachoking
Update flexget/plugins/clients/qbittorrent.py
4338618 
Co-authored-by: Chase Sterling <chase.sterling@gmail.com>
@whiteout12
Copy link
Copy Markdown
Contributor Author

whiteout12 commented Dec 14, 2021

I have made the changes from last review. Is there anything else I need to fix?

@gazpachoking
Copy link
Copy Markdown
Member

gazpachoking commented Dec 15, 2021

Looks good to me, thanks!

@gazpachoking gazpachoking merged commit 0a7dbe7 into Flexget:develop Dec 15, 2021
@whiteout12 whiteout12 deleted the qbt-tags branch December 17, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gazpachoking gazpachoking gazpachoking approved these changes

+1 more reviewer

@BrutuZ BrutuZ BrutuZ left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@whiteout12 @gazpachoking @BrutuZ