[fix] set Manipulate to ignore rejected entries#3126
Merged
paranoidi merged 5 commits intoFlexget:developfrom Sep 7, 2021
Merged
[fix] set Manipulate to ignore rejected entries#3126paranoidi merged 5 commits intoFlexget:developfrom
paranoidi merged 5 commits intoFlexget:developfrom
Conversation
Member
|
I think this makes more sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Currently
manipulateprocesses rejected entries, which is problematic. I don't understand the reason for this in the first place.For example, I want to use
manipulateto replacetitlewithimdb_name. Some entries don't have valid imdb metadata, which causesmanipulateto crash when trying to settitletoNone. This could be solved by usingrequired_field: imdb_nameand settingplugin_priorityformanipulateto lower thanrequired_fieldbut it doesn't work becausemanupulatewill process rejected entries also. This causes the task to crash.Detailed changes:
set
manipulateto ignore rejected entries