Skip to content

[add] quality: add color range#2941

Merged
gazpachoking merged 2 commits intoFlexget:developfrom
soloam:quality_enhancement
May 11, 2021
Merged

[add] quality: add color range#2941
gazpachoking merged 2 commits intoFlexget:developfrom
soloam:quality_enhancement

Conversation

@soloam
Copy link
Copy Markdown
Contributor

@soloam soloam commented Apr 29, 2021 •
edited
Loading

Motivation for changes:

Hi, now that HDR is becoming more and more common, is it time to create a new component called color range

Detailed changes:

  • quality.py - Add support to color range

BREAKING CHANGES: Removed 10bit from codecs

Addressed issues:

Implemented feature requests:

Config usage if relevant (new plugin or updated schema):

tasks:
  quality_test:
    disable:
      - remember_rejected
      - seen
      - retry_failed
      - seen_info_hash
    quality: hdrplus+

Log and/or tests output (preferably both):

flexget execute --inject "My Movie UHD 2160P HDR+ DTS-HD" --dump

2021-04-29 01:07:30 VERBOSE  task_queue                    There are 1 tasks to execute. Shutdown will commence when they have completed.
2021-04-29 01:07:30 VERBOSE  details       quality_test    Summary - Accepted: 0 (Rejected: 0 Undecided: 1 Failed: 0)
2021-04-29 01:07:30 WARNING  task          quality_test    Task doesn't have any output plugins, you should add (at least) one!
-- Undecided: --------------------------
title            : My Movie UHD 2160P HDR+ DTS-HD
url              : http://localhost/inject/dB1LsEkNcTJjuOvwPgziHeQCyXIhMZ
original_url     : http://localhost/inject/dB1LsEkNcTJjuOvwPgziHeQCyXIhMZ
media_id         : <LazyField - value will be determined when it is accessed>
original_title   : My Movie UHD 2160P HDR+ DTS-HD
quality          : 2160p hdrplus dtshd
task             : quality_test

flexget execute --inject "My Movie UHD 2160P HDR DTS-HD" --dump

2021-04-29 01:08:13 VERBOSE  task_queue                    There are 1 tasks to execute. Shutdown will commence when they have completed.
2021-04-29 01:08:13 VERBOSE  task          quality_test    REJECTED: `My Movie UHD 2160P HDR DTS-HD` by quality plugin because `2160p hdr10 dtshd` does not match any of quality requirements: `hdrplus+`
2021-04-29 01:08:13 VERBOSE  details       quality_test    Summary - Accepted: 0 (Rejected: 1 Undecided: 0 Failed: 0)
2021-04-29 01:08:13 WARNING  task          quality_test    Task doesn't have any output plugins, you should add (at least) one!
-- Rejected: ---------------------------
title            : My Movie UHD 2160P HDR DTS-HD
url              : http://localhost/inject/Oc1KUiNMnlstgjHRk3ADZIfdx6p0BY
original_url     : http://localhost/inject/Oc1KUiNMnlstgjHRk3ADZIfdx6p0BY
media_id         : <LazyField - value will be determined when it is accessed>
original_title   : My Movie UHD 2160P HDR DTS-HD
quality          : 2160p hdr dtshd
task             : quality_test

To Do:

I tested the regex against several entries from trackers and seems ok, but:

  • Fine Tune Regex

@BrutuZ
Copy link
Copy Markdown
Contributor

BrutuZ commented Apr 29, 2021 •
edited
Loading

Dropping my two cents out here, feel free to pick them up or leave them on the ground xD

  • I'm kind of missing a more intuitive hdr item. Any reason not to call hdr10 just hdr and give it a lower ranking than hdrp (hdrplus is probably clearer too)?
  • The p on Hi10/8p should be optional, I have seen just Hi10 floating around.

[feat!] won't be auto-added to the Changelog 😝

Flexget/update-changelog.py

Lines 12 to 18 in 5bf24e7

CATEGORIES = [
('### Added\n', ['add', 'added', 'feature']),
('### Changed\n', ['change', 'changed', 'update']),
('### Fixed\n', ['fix', 'fixed']),
('### Deprecated\n', ['deprecate', 'deprecated']),
('### Removed\n', ['remove', 'removed']),
]

EDIT: Just noticed the order doesn't match the priority number, nvm that part

@soloam soloam changed the title [feat!] quality: add color range [add] quality: add color range Apr 29, 2021
@gazpachoking gazpachoking merged commit 1bf79a7 into Flexget:develop May 11, 2021
@gazpachoking
Copy link
Copy Markdown
Member

gazpachoking commented May 11, 2021

Thanks! Can you update the wiki with this info?

@soloam
Copy link
Copy Markdown
Contributor Author

soloam commented May 11, 2021

I'll do! Thanks

@denngie
Copy link
Copy Markdown

denngie commented May 16, 2021

Great work @soloam! Quick question, the doc page for quality lists hdr above hdrplus, that can't be intended right? Because I see in the code you wrote that hdrplus has a higher "score" but is after the hdr because of regexp I guess.

@soloam
Copy link
Copy Markdown
Contributor Author

soloam commented May 16, 2021

You are correct, tks for the notice, I'll fix it

@soloam
Copy link
Copy Markdown
Contributor Author

soloam commented May 16, 2021

Done @denngie tks

@soloam soloam deleted the quality_enhancement branch May 25, 2021 22:05
@eatsleepcoderepeat-gl
Copy link
Copy Markdown

eatsleepcoderepeat-gl commented Aug 9, 2021 •
edited
Loading

Please add information regarding this breaking change to the UpgradeActions page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Color range(HDR) as a quality component?

5 participants

@soloam @BrutuZ @gazpachoking @denngie @eatsleepcoderepeat-gl