season_packs doesn't reject episodes if in the same feed and with target and timeframe #2849
Description
Expected behaviour:
According to the documentation, season_packs: yes, should accept seasons packs if no other episode is downloaded, and reject episodes if the season pack is downloaded.
Actual behaviour:
This works if the season pack and the episode are not both in the same input feed and not with timeframe and target.
If both appear at the same time, and the series contains timeframe and target, they are both accepted. Flexget should only accept one of them.
Steps to reproduce:
- Step 1: Test That Works with normal series configuration
flexget --debug execute --task "xTV_Test_season_pack_1" --inject "Lost S01 720p hdtv h264" --inject "Lost S01E01 720 hdtv h264"
2021-02-11 16:49:22 DEBUG series xTV_Test_season_pack_1 current: <Season(id=54,identifier=S01,season=1,completed=False)>
2021-02-11 16:49:22 VERBOSE task xTV_Test_season_pack_1 ACCEPTED: `Lost S01 720p hdtv h264` by series plugin because matches quality
2021-02-11 16:49:22 DEBUG series xTV_Test_season_pack_1 adding season number `1` to accepted seasons for this task
2021-02-11 16:49:22 DEBUG series xTV_Test_season_pack_1 start with entities: ['Lost S01E01 720 hdtv h264']
2021-02-11 16:49:22 VERBOSE task xTV_Test_season_pack_1 REJECTED: `Lost S01E01 720 hdtv h264` by series plugin because already accepted season pack for season `1` in this task
-
Step 2: Forget the Season
flexget series forget "Lost (2004)" -
Step 3: Test with timeframe and target
flexget --debug execute --task "xTV_Test_season_pack_2" --inject "Lost S01 720p hdtv h264" --inject "Lost S01E01 720 hdtv h264"
2021-02-11 16:50:50 DEBUG series xTV_Test_season_pack_2 Accepted by series. `Lost S01 720p hdtv h264` meets quality requirement `720p webrip+ h264+`.
2021-02-11 16:50:50 VERBOSE task xTV_Test_season_pack_2 ACCEPTED: `Lost S01 720p hdtv h264` by series plugin because target quality
2021-02-11 16:50:50 DEBUG series xTV_Test_season_pack_2 start with entities: ['Lost S01E01 720 hdtv h264']
2021-02-11 16:50:50 DEBUG series xTV_Test_season_pack_2 current entities: ['Lost S01E01 720 hdtv h264']
2021-02-11 16:50:50 DEBUG series xTV_Test_season_pack_2 quality req: 720p|1080p webrip+
2021-02-11 16:50:50 DEBUG series xTV_Test_season_pack_2 -------------------- process_propers -->
2021-02-11 16:50:50 DEBUG series xTV_Test_season_pack_2 propers - downloaded qualities: {}
2021-02-11 16:50:50 DEBUG series xTV_Test_season_pack_2 continuing w. entities: ['Lost S01E01 720 hdtv h264']
2021-02-11 16:50:50 DEBUG series xTV_Test_season_pack_2 best entity is: `Lost S01E01 720 hdtv h264`
2021-02-11 16:50:50 DEBUG series xTV_Test_season_pack_2 -------------------- tracking -->
2021-02-11 16:50:50 DEBUG series.db xTV_Test_season_pack_2 no episodes found for series `Lost (2004)` with parameters season: None, downloaded: True
2021-02-11 16:50:50 DEBUG series.db xTV_Test_season_pack_2 no season packs found for series `Lost (2004)` with parameters season: None, downloaded: True
2021-02-11 16:50:50 DEBUG series xTV_Test_season_pack_2 latest download: None
2021-02-11 16:50:50 DEBUG series xTV_Test_season_pack_2 current: <Episode(id=6159,identifier=S01E01,season=1,number=1)>
2021-02-11 16:50:50 DEBUG series xTV_Test_season_pack_2 Accepted by series. `Lost S01E01 720 hdtv h264` meets quality requirement `720p webrip+ h264+`.
2021-02-11 16:50:50 VERBOSE task xTV_Test_season_pack_2 ACCEPTED: `Lost S01E01 720 hdtv h264` by series plugin because target quality
Config:
xTV_Test_season_pack_1:
disable:
- remember_rejected
- seen
- retry_failed
- seen_info_hash
series:
- Lost (2004):
identified_by: ep
quality: 720p|1080p webrip+
season_packs: true
thetvdb_lookup: true
trakt_lookup: true
xTV_Test_season_pack_2:
disable:
- remember_rejected
- seen
- retry_failed
- seen_info_hash
series:
- Lost (2004):
identified_by: ep
quality: 720p|1080p webrip+
timeframe: 4 hours
target: 720p webrip+ h264+
season_packs: true
thetvdb_lookup: true
trakt_lookup: trueAdditional information:
- FlexGet version: 3.1.102
- Python version: Python 3.7.3
- Installation method: VENV
- Using daemon (yes/no): yes (but tested also without daemon)
- OS and version: Debian 10