Skip to content

Insufficient info on a rejected entry's quality requirements #2801

@girtsl

Description

@girtsl

Expected behaviour:

When an entry is [correctly] rejected the [verbose] log message includes the reason for rejection. For instance, if it's rejected by the quality plugin, the log message includes what quality is expected.

Actual behaviour:

If an entry doesn't match the quality requirements, the log message shows the entry's parsed quality but not the expected quality - 1080p webdl h264 aac does not match quality requirement [<Requirements(self)>].
Not very familiar with Python but it looks like object serialization or destructuring gone wrong.

Steps to reproduce:

Run a task that expects a certain quality of the produced entries.

Config:

    quality: 
      - 2160p+ webrip+

I hope the description is enough to reproduce the issue but can provide the full config if needed.

Log:

2021-01-08 02:23:41 VERBOSE  task          download-movies-2160 REJECTED: `title` by quality plugin because 1080p bluray does not match quality requirement [<Requirements(self)>]
2021-01-08 02:23:41 VERBOSE  task          download-movies-2160 REJECTED: `title` by quality plugin because 1080p webdl h264 aac does not match quality requirement [<Requirements(self)>]

I've omitted the titles as they are not really relevant.

Additional information:

  • FlexGet version: 3.1.95
  • Python version: 3.7.7
  • Installation method: container
  • Using daemon (yes/no): yes
  • OS and version: can't find anything in /etc/ that would give me the version but the container I'm using appears to be based on Alpine 3.10

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions