flexget/manager.py: Updated logging level for Daemon running messages by s-m-martin · Pull Request #2748 · Flexget/Flexget

s-m-martin · 2020-10-10T02:25:12Z

Motivation for changes:

"Daemon running" messages were filling up the INFO level log. The messages don't really add any value, so should really only be used during debug.

Detailed changes:

a single line change of logger.info to logger.debug on line 502 of manager.py

Addressed issues:

Fixes Log full of "Daemon running." messages #2729

Log and/or tests output (preferably both):

(flexget) ---:~/Flexget$ pytest -n auto
==================================================== test session starts ====================================================
platform linux -- Python 3.8.5, pytest-5.1.3, py-1.9.0, pluggy-0.13.1
rootdir: /home/---/Flexget, inifile: setup.cfg, testpaths: flexget/tests
plugins: xdist-1.29.0, forked-1.3.0, cov-2.5.1
gw0 [1354]
...s.................................................................................ss.............................s [  8%]
ssss.........s................ssssss..................s..............................s......s........................ [ 17%]
.............s..........s.........................s.................................................................. [ 25%]
..................................................................................................................... [ 34%]
...................................................................................................................x. [ 43%]
.............X....................................................................................................... [ 51%]
..................................................................................................................... [ 60%]
...........................s..X......................X..........................s..x......................x.......... [ 69%]
............................ssss.s..........................................X........................................ [ 77%]
.......x............................X................................................................................ [ 86%]
..................................................................................................................... [ 95%]
...................................................................                                                   [100%]
===================================================== warnings summary ======================================================
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
/home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120
  /home/---/flexget/lib/python3.8/site-packages/flask_restx/namespace.py:120: DeprecationWarning: The parser attribute is deprecated, use expect instead
    handle_deprecations(doc)

/home/---/flexget/lib/python3.8/site-packages/dateutil/parser.py:587
  /home/---/flexget/lib/python3.8/site-packages/dateutil/parser.py:587: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working
    if (isinstance(tzinfos, collections.Callable) or

/home/---/flexget/lib/python3.8/site-packages/sqlalchemy/orm/query.py:195
  /home/---/flexget/lib/python3.8/site-packages/sqlalchemy/orm/query.py:195: SADeprecationWarning: Plain string expression passed to Query() should be explicitly declared using literal_column(); automatic coercion of this value will be removed in SQLAlchemy 1.4
    entity_wrapper(self, ent)

-- Docs: https://docs.pytest.org/en/latest/warnings.html
====================== 1317 passed, 28 skipped, 4 xfailed, 5 xpassed, 47 warnings in 388.76s (0:06:28) ======================

… messages #2729 - "Daemon running" messages were filling up the INFO level log. The messages don't really add any value, so should really only be used during debug.

gazpachoking · 2020-10-10T13:44:35Z

Hmm. This log message is from when you run flexget daemon status. If this moves to debug level, won't that mean there is no output from that command?

s-m-martin · 2020-10-10T15:40:59Z

Hmm. This log message is from when you run flexget daemon status. If this moves to debug level, won't that mean there is no output from that command?

If you have log level set as info, then yes, the only way you would get output is if you set the log level at debug. Just trying to provide a fix for #2729 here. The larger question is, why does flexget daemon status need to have a message in the info log? If you run the command, you receive a result to terminal already.

gazpachoking · 2020-10-10T15:43:50Z

Oh yes, probably changing this from a log call to a console message would be good. I like that much better than moving it to debug log, as that would break the expectations of the daemon status command.

github-actions · 2021-05-03T14:43:49Z

This PR is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 60 days.

flexget/manager.py: Updated logging level to debug for Daemon running…

e3e7d51

… messages #2729 - "Daemon running" messages were filling up the INFO level log. The messages don't really add any value, so should really only be used during debug.

github-actions bot added the Stale label May 3, 2021

gazpachoking closed this in 93715a7 May 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

flexget/manager.py: Updated logging level for Daemon running messages#2748

flexget/manager.py: Updated logging level for Daemon running messages#2748
s-m-martin wants to merge 1 commit intoFlexget:developfrom
s-m-martin:develop

s-m-martin commented Oct 10, 2020

Uh oh!

gazpachoking commented Oct 10, 2020

Uh oh!

s-m-martin commented Oct 10, 2020

Uh oh!

gazpachoking commented Oct 10, 2020

Uh oh!

github-actions bot commented May 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

s-m-martin commented Oct 10, 2020

Motivation for changes:

Detailed changes:

Addressed issues:

Log and/or tests output (preferably both):

Uh oh!

gazpachoking commented Oct 10, 2020

Uh oh!

s-m-martin commented Oct 10, 2020

Uh oh!

gazpachoking commented Oct 10, 2020

Uh oh!

github-actions bot commented May 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants