[fix] filelist_api: NameError: name 'valid_extras'#2709
Merged
liiight merged 1 commit intoFlexget:developfrom Jul 14, 2020
Merged
[fix] filelist_api: NameError: name 'valid_extras'#2709liiight merged 1 commit intoFlexget:developfrom
liiight merged 1 commit intoFlexget:developfrom
Conversation
Fixes a crash in the new `filelist_api` plugin:
```
Traceback (most recent call last):
File "/usr/lib/python3.8/site-packages/flexget/task.py", line 535, in __run_plugin
result = method(*args, **kwargs)
File "/usr/lib/python3.8/site-packages/flexget/event.py", line 22, in __call__
return self.func(*args, **kwargs)
File "/usr/lib/python3.8/site-packages/flexget/plugins/input/discover.py", line 294, in on_task_input
return self.execute_searches(config, entries, task)
File "/usr/lib/python3.8/site-packages/flexget/plugins/input/discover.py", line 134, in execute_searches
search_results = search.search(task=task, entry=entry, config=plugin_config)
File "/usr/lib/python3.8/site-packages/flexget/plugin.py", line 127, in wrapped_func
return func(*args, **kwargs)
File "/usr/lib/python3.8/site-packages/flexget/components/sites/sites/filelist_api.py", line 102, in search
params.update({extra: 1 for extra in valid_extras if config.get(extra)})
NameError: name 'valid_extras' is not defined
```
Done through the GitHub UI, so I haven't tested this, but it sure seems like a simple and obvious fix.
Member
|
thanks for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a crash in the new
filelist_apiplugin:Done through the GitHub UI, so I haven't tested this, but it sure seems like a simple and obvious fix.
Motivation for changes:
Detailed changes:
Addressed issues:
Implemented feature requests:
Config usage if relevant (new plugin or updated schema):
Log and/or tests output (preferably both):
To Do: