Fail entries instead of throwing a PluginError when Jinja templating fails#2685
Merged
liiight merged 2 commits intoFlexget:developfrom May 27, 2020
Merged
Fail entries instead of throwing a PluginError when Jinja templating fails#2685liiight merged 2 commits intoFlexget:developfrom
liiight merged 2 commits intoFlexget:developfrom
Conversation
Member
|
How about copy and other file operations? All should behave same. |
Contributor
Author
They all use the same code, despite the misleading file name. |
Contributor
Author
|
I renamed the file because it's definitely confusing. |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Flexget currently aborts the entire task when JINJA2 templating failes (e.g. when the
all_seriesplugin fails to parse an entry). This is super annoying, since it skips processing any additional entries after the failures.Detailed changes:
PluginErrorfor usingentry.fail()