Skip to content

[change] new search plugin for Filelist with API#2658

Merged
liiight merged 2 commits intoFlexget:developfrom
putyn:filelist_api
May 3, 2020
Merged

[change] new search plugin for Filelist with API#2658
liiight merged 2 commits intoFlexget:developfrom
putyn:filelist_api

Conversation

@putyn
Copy link
Copy Markdown
Contributor

@putyn putyn commented Apr 21, 2020

Motivation for changes:

Filelist released an API which can be used to search for torrents, this should replace the old search plugin which scraped the site.

Copy link
Copy Markdown
Member

@liiight liiight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! A few changes are requested

@putyn
Copy link
Copy Markdown
Contributor Author

putyn commented Apr 23, 2020

@liiight - is there a way to make the other plugin deprecated and move users to the new one ?

@liiight
Copy link
Copy Markdown
Member

liiight commented Apr 23, 2020

@putyn you can use the 'deprecated' keyword in the schema of the old plugin. See how its used in other places

@putyn putyn force-pushed the filelist_api branch 2 times, most recently from d030b79 to 774af28 Compare April 24, 2020 12:28
@liiight
Copy link
Copy Markdown
Member

liiight commented Apr 24, 2020

Just last comment remaining and we're good to go 😃

@putyn
Copy link
Copy Markdown
Contributor Author

putyn commented Apr 25, 2020

Done, I also squashed all the commits in one hopefully I did it right as I am still learning to use git 😄
Regarding the old plugin, should we deprecate it ? If yes new pull request or can we include the change in this one ?

@liiight
Copy link
Copy Markdown
Member

liiight commented Apr 26, 2020

You can include the change in this PR

@putyn
Copy link
Copy Markdown
Contributor Author

putyn commented Apr 27, 2020

old plugin deprecated, I think we are good to go 😄

@putyn
Copy link
Copy Markdown
Contributor Author

putyn commented May 2, 2020

@liiight - do you think we need more changes ?

@liiight liiight changed the title new search plugin for Filelist with API [change] new search plugin for Filelist with API May 3, 2020
@liiight liiight merged commit 01d1f46 into Flexget:develop May 3, 2020
@liiight
Copy link
Copy Markdown
Member

liiight commented May 3, 2020

Merged. Thanks for your patience and collaboration on this @putyn!

@FlexGet-Bot
Copy link
Copy Markdown
Contributor

This pull request has been mentioned on Forum - FlexGet. There might be relevant details there:

https://discuss.flexget.com/t/filelist-ro-search-plugin-broken/5024/8

@putyn putyn deleted the filelist_api branch January 16, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants