Skip to content

[fix] Removed pillow and pystray as dependencies#2652

Merged
liiight merged 1 commit intodevelopfrom
make_tray_icon_deps_optional
Apr 13, 2020
Merged

[fix] Removed pillow and pystray as dependencies#2652
liiight merged 1 commit intodevelopfrom
make_tray_icon_deps_optional

Conversation

@liiight
Copy link
Copy Markdown
Member

@liiight liiight commented Apr 13, 2020 •
edited
Loading

Motivation for changes:

Pillow needs compilation which hurts Flexget's compatibility.

Detailed changes:

  • Removed pillow and pystray from deps. If someone wants to run the tray icon, they can install them manually.

Addressed issues:

@liiight liiight changed the title [fix] removed pillow and pystray as dependencies, making them opt… Removed pillow and pystray as dependencies Apr 13, 2020
@liiight liiight changed the title Removed pillow and pystray as dependencies Removed pillow and pystray as dependencies Apr 13, 2020
@liiight liiight changed the title Removed pillow and pystray as dependencies [fix] Removed pillow and pystray as dependencies Apr 13, 2020
@liiight liiight merged commit c1e29ea into develop Apr 13, 2020
@liiight liiight deleted the make_tray_icon_deps_optional branch April 13, 2020 13:55
@FlexGet-Bot
Copy link
Copy Markdown
Contributor

FlexGet-Bot commented Apr 13, 2020

This pull request has been mentioned on Forum - FlexGet. There might be relevant details there:

https://discuss.flexget.com/t/dependencies-on-non-pure-python-modules/5086/4

@liiight liiight mentioned this pull request Apr 13, 2020
Closed
@alirz1
Copy link
Copy Markdown

alirz1 commented Apr 17, 2020

So when i try to install flexget on a synology Nas, using Python 3.x instlaled via entware.
It fails while trying to install pillow. So looks like that dependency is still there?

Im using this article for the isntallation of flexget:
https://flexget.com/InstallWizard/SynologyNAS/PythonPackage

StefftheEmperor2 pushed a commit to StefftheEmperor2/Flexget that referenced this pull request Apr 25, 2020
@liiight
[fix] Removed pillow and pystray as dependencies (Flexget#2652)
763d25b
@2sheds
Copy link
Copy Markdown

2sheds commented May 14, 2020 •
edited
Loading

It fails while trying to install pillow. So looks like that dependency is still there?

Came here for a similar thing. This change hasn't made it into a new release yet, so if you install from pip (which is on 3.1.51) it will still have the dependency. Our options right now are to wait until 3.1.52 or build from source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dependencies on non pure Python modules

4 participants

@liiight @FlexGet-Bot @alirz1 @2sheds