Merged
Conversation
Member
|
Looks good to me. Thanks for contributing! |
liiight
reviewed
Apr 1, 2020
| 'www.ettvdl.com', | ||
| ] | ||
|
|
||
| class UrlRewriteETTV: |
Member
There was a problem hiding this comment.
seems there's a missing line here. We style the code with black. You can install pre-commit and enable it for the repo and it will take care of this stuff
| raise UrlRewritingError(e) | ||
| tag_a = soup.find('a', attrs={'class': 'download_link'}) | ||
| if not tag_a: | ||
| raise UrlRewritingError('Unable to locate download link from url %s' % url) |
Member
|
Thanks! |
StefftheEmperor2
pushed a commit
to StefftheEmperor2/Flexget
that referenced
this pull request
Apr 25, 2020
* [add] ETTV rewriter plugin * Ignore VSCode settings * Formatting * Use f-strings * Use select instead of find
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Make ETTV play nice with html plugin
Detailed changes: