[add] rutracker.org topic pages urlrewrite#2609
Conversation
8b7dbcd to
34b2743
Compare
|
Could you please provide sample how to configure rutracker with magnet? |
7ebfa2f to
85a32b8
Compare
|
Thanks @liiight for the review, I updated my PR with all your suggestions, and also added more features:
If you have time, could you please reply to my questions in my initial comment? Thanks ! |
|
@githubbla It should work using their forum rss/atom feed: http://feed.rutracker.cc/atom/f/0.atom If you also want music parsing I have a somewhat working version 0 there: https://github.com/Niluge-KiWi/Flexget/tree/dev-music |
85a32b8 to
5742fbb
Compare
|
@liiight If you have time, could you please reply to my questions in my initial comment? Thanks ! |
|
@Niluge-KiWi I'll try to respond ASAP |
|
No urgency at all!
|
liiight
left a comment
There was a problem hiding this comment.
Some minor tweaks requested, looks good
Uses api.t-ru.org to get topic data from topic id: get torrent hash, use it to reconstruct a magnet URI: - add all 4 rutracker trackers servers - add topic title as Display Name Test url_rewrite.
5742fbb to
69e982a
Compare
|
@liiight last round of requested changes done! Side note: most of your (valid) remarks also apply to other files in |
|
@Niluge-KiWi thank you for your contribution! |
|
Unfortunately this completely breaks external RSS feeds with direct torrent links to RuTracker. Can the old rutracker_auth plugin be restored and work in parallel with this? |
|
@n00buk In that case wouldn't it be fine to just disable the url rewriting for the task? disable:
- urlrewriting |
|
@BrutuZ, I might be doing it wrong, but it didn't work. Here is what i tried... ... and what I got ... |
Motivation for changes:
Get magnet url from rutracker.org topics.
Detailed changes:
Config usage if relevant (new plugin or updated schema):
rutracker.org has an atom feed: http://feed.rutracker.cc/atom/f/0.atom
Log and/or tests output (preferably both):
I added a test in
tests/test_urlrewriting.py. Not sure it's the best way to do it (and it requires online access: don't know if we want to mock the network call nor how to do it.To Do:
rutracker_authplugin: I'm not sure it's that useful since torrents are public there, and my plugin creates magnet link without needing to really download.torrentfiles from rutracker.org.site_rutracker.pytorutracker.pyif the old plugin is removed, or merge both?