Skip to content

[added] Hebits search plugin#2559

Merged
liiight merged 17 commits intodevelopfrom
hebits
Jan 8, 2020
Merged

[added] Hebits search plugin#2559
liiight merged 17 commits intodevelopfrom
hebits

Conversation

@liiight
Copy link
Copy Markdown
Member

@liiight liiight commented Jan 6, 2020 •
edited
Loading

Motivation for changes:

Add a search plugin for hebits.net

Detailed changes:

I tried a few new things with this one.

Config usage if relevant (new plugin or updated schema):

      from:
        - hebits:
            user_name: bar
            password: foo
            category:
            - hd_movies
            free: yes
            double: no
            triple: no
            pack: no
            order_by: date
            order_desc: yes

Categories:

class HEBitsCategory(Enum):
    pc_games = 21
    console_games = 33
    hd_movies = 27
    bluray = 36
    dvdr = 20
    sd_movies = 19
    il_movies = 25
    top_imdb = 34
    hd_shows = 1
    hd_shows_subs = 24
    il_hd_shows = 37
    il_shows = 7
    animated = 23
    music = 28
    flac_music = 31
    il_music = 6
    concerts = 35
    soundtrack = 30
    mobile = 32
    ebooks = 26
    apps = 22
    misc = 29
    xxx = 9
    sport = 41

Sort options:

class HEBitsSort(Enum):
    names = 1
    files = 2
    comments = 3
    date = 4
    size = 5
    completed = 6
    uploaders = 7
    downloaders = 8
    uploader = 9

@liiight liiight requested review from cvium and gazpachoking January 6, 2020 13:19
cvium
cvium reviewed Jan 7, 2020
View reviewed changes
cvium
cvium approved these changes Jan 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@cvium cvium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how I feel about the new requirements though, but if it's a better lib, then sure.

@liiight
Copy link
Copy Markdown
Member Author

liiight commented Jan 7, 2020

I found it much simpler and cleaner to use than bs4. It has a lot of deps since it can also render JS pages, requiring it to install an engine. we could use if for SPA which we couldn't do with bs4 (maybe even use if for imdb?)

paranoidi
paranoidi approved these changes Jan 7, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@paranoidi paranoidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of new dependencies :/

flexget/components/sites/sites/hebits.py Outdated
Copy link
Copy Markdown
Member

@paranoidi paranoidi Jan 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type hints are awesome for larger projects, but if we start using them we basically need to be using mypy too :)

Copy link
Copy Markdown
Member Author

@liiight liiight Jan 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this is just a POC. I feel we should actively pursue adding these in all new PRs and maybe even make a move in adding ourselves.

gazpachoking
gazpachoking reviewed Jan 7, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@gazpachoking gazpachoking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fully convinced by requests-html yet. I'm also not totally against it though.

requirements.txt Outdated
Copy link
Copy Markdown
Member

@gazpachoking gazpachoking Jan 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. This is a dummy package, I don't see it directly in requests-html setup.py file, I wonder where it's getting added.

Copy link
Copy Markdown
Member Author

@liiight liiight Jan 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a pip-tools bug? kinda doubt it

@liiight liiight changed the title Hebits [added] Hebits search plugin Jan 8, 2020
@liiight liiight merged commit 2a0aece into develop Jan 8, 2020
@liiight liiight deleted the hebits branch January 8, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gazpachoking gazpachoking gazpachoking left review comments

@paranoidi paranoidi paranoidi approved these changes

@cvium cvium cvium approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liiight @gazpachoking @paranoidi @cvium