Support qBittorrent v4.1+, fixes #2522#2525
Merged
liiight merged 2 commits intoFlexget:developfrom Dec 11, 2019
Merged
Conversation
liiight
reviewed
Dec 11, 2019
Member
liiight
left a comment
There was a problem hiding this comment.
Are these changes backwards compatible?
Contributor
Author
No, it supports qBittorrent v4.1.0+ released at 5/05/2018 |
Member
|
Hmm, that could be a problem. Is there a way to programmetically determine the api version and use the relevant calls? |
Contributor
Author
Yes, it is possible. I will start working on it. |
Contributor
Author
Now it supports both versions. |
Member
|
Thanks a lot, awesome work on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Plugin qBittorrent stopped working with qBittorrent v4.2
Detailed changes:
Addressed issues: