[change] tvdb_lookup - Always have the main poster as the first entry of tvdb_posters#2524
Merged
liiight merged 4 commits intoFlexget:developfrom Dec 10, 2019
Merged
Conversation
Update more related cassettes
liiight
requested changes
Dec 10, 2019
Member
|
Yes, leave logger to do it's own interpolation
…On Tue, Dec 10, 2019, 18:26 BrutuZ ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In flexget/components/thetvdb/api_tvdb.py
<#2524 (comment)>:
> @@ -257,10 +257,12 @@ def get_posters(self):
if not self._posters:
log.debug('Getting top 5 posters for series %s', self.name)
try:
+ poster_main = TVDBRequest().get('series/%s' % self.id).get('poster')
On it 👍 .
Just one more question (I hope): Leave log entries alone to let it handle
the parameters internally or convert them to f-strings too?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2524?email_source=notifications&email_token=ABBMANL4IFOJYAXINCLJN2TQX67KJA5CNFSM4JYROGD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOVO6VY#discussion_r356140121>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBMANJUIEPQW5MCE7LOR4LQX67KJANCNFSM4JYROGDQ>
.
|
Member
|
Thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
TheTVDB returns posters in a random order and Flexget caps the list to 5 entries. I like to use the main poster (curated to be used by the site) on my notifications and given the aforementioned actions, it's not always on the list, and when it is there is no way to determine which entry t is.
Detailed changes:
[unrelated] Changed URL for the posters CDN to the new one post TheTVDB's v3 migration. There are currently 301 redirects in place at the old URL but they did recommend changing it wherever possible./series/{id}endpoint and start the list with itAddressed issues: