[fix] Handle exception when api_bluray fails to get content#2468
Merged
gazpachoking merged 3 commits intoFlexget:developfrom May 3, 2021
Merged
[fix] Handle exception when api_bluray fails to get content#2468gazpachoking merged 3 commits intoFlexget:developfrom
gazpachoking merged 3 commits intoFlexget:developfrom
Conversation
liiight
requested changes
Oct 24, 2019
Remove unnecessary break
liiight
reviewed
Oct 24, 2019
| try: | ||
| movie_info_response = requests.get(self.url).content | ||
| except (requests.RequestException, ConnectionError) as e: | ||
| raise PluginError("Couldn't connect to blu-ray.com. %s" % self.url) |
Member
There was a problem hiding this comment.
hmm, now i'm thinking maybe PluginWarning would be better here so we won't abort the task. @gazpachoking @cvium WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Flexget would crash if connection to blu-ray.com failed when trying to update movie data such as release date.
Detailed changes:
try:Addressed issues:
To Do: