Skip to content

[fix] exists_movie support movie same name different year#2455

Merged
liiight merged 3 commits intodevelopfrom
unknown repository
Oct 25, 2019
Merged

[fix] exists_movie support movie same name different year#2455
liiight merged 3 commits intodevelopfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 14, 2019

Motivation for changes:

Currently exists_movie has a bug on movies with the same name but different year, there cases like The Lion King (1994) and The Lion King (2019) and currently exists_movie reject it due has the same name, this PR fix that bug

Detailed changes:

  • add the year of the movie to the key identifier to allow movie with same neam and different year

Addressed issues:

  • No open issue yet

Log and/or tests output (preferably both):

adding: The Lion King 1994
adding: Pokémon Detective Pikachu 2019
adding: Ant-Man and the Wasp 2018
Teen Titans Go! To the Movies 2018
2019-10-14 12:34 VERBOSE  task          copy-movies     REJECTED: `Teen Titans Go! To the Movies (2018)[1080p]` by exists_movie plugin because movie exists
Steven Universe: The Movie 2019
2019-10-14 12:34 VERBOSE  task          copy-movies     REJECTED: `steven.universe.the.movie.2019.hdrip.720p.latino` by exists_movie plugin because movie exists
The Lion King 2019
El Camino: A Breaking Bad Movie 2019
2019-10-14 12:34 VERBOSE  task          copy-movies     REJECTED: `El.camino.a.breaking.bad.movie.2019.1080p-dual-lat-cinecalidad.is` by exists_movie plugin because movie exists
2019-10-14 12:34 VERBOSE  details       copy-movies     Summary - Accepted: 1 (Rejected: 19 Undecided: 0 Failed: 0)
2019-10-14 12:34 INFO     copy          copy-movies     Creating destination directory `/movies/The Lion King (2019)`

liiight
liiight requested changes Oct 24, 2019
View reviewed changes
@liiight liiight merged commit 46c7e32 into Flexget:develop Oct 25, 2019
@liiight
Copy link
Copy Markdown
Member

liiight commented Oct 25, 2019

Thanks for this!

@ghost ghost deleted the fix-exists-movie-year branch October 25, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@liiight