Skip to content

Convert form plugin to use mechanicalsoup rather than mechanize#2224

Merged
gazpachoking merged 1 commit intodevelopfrom
formlogin_mechanicalsoup
Oct 12, 2018
Merged

Convert form plugin to use mechanicalsoup rather than mechanize#2224
gazpachoking merged 1 commit intodevelopfrom
formlogin_mechanicalsoup

Conversation

@gazpachoking
Copy link
Copy Markdown
Member

@gazpachoking gazpachoking commented Oct 12, 2018

Motivation for changes:

  • mechanize does not work on python 3
  • mechanize did not use our task's requests session

Detailed changes:

  • Uses mechanicalsoup to get/submit forms rather than mechanize
  • mechanicalsoup now uses our task.requests session, improving compatibility with other plugins

Addressed issues:

@gazpachoking gazpachoking merged commit 3e36b1b into develop Oct 12, 2018
@gazpachoking gazpachoking deleted the formlogin_mechanicalsoup branch January 28, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gazpachoking