Skip to content

imdb_list plugin doesn't handle timeouts #2114

@lepinkainen

Description

@lepinkainen

Expected behaviour:

Timeout is handled and doesn't produce a CRITICAL error

Actual behaviour:

2018-04-07 23:02 CRITICAL task          imdb_watchlist  BUG: Unhandled error in plugin imdb_list: HTTPConnectionPool(host='www.imdb.com', port=80): Read timed out.
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/flexget/task.py", line 486, in __run_plugin
    return method(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/flexget/event.py", line 23, in __call__
    return self.func(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/flexget/plugins/list/imdb_list.py", line 372, in on_task_input
    return list(self.get_list(config))
  File "/usr/local/lib/python2.7/dist-packages/flexget/plugins/list/imdb_list.py", line 277, in __iter__
    return iter(self.items)
  File "/usr/local/lib/python2.7/dist-packages/flexget/plugins/list/imdb_list.py", line 221, in items
    for row in csv_dictreader(lines):
  File "/usr/local/lib/python2.7/dist-packages/flexget/plugins/list/imdb_list.py", line 75, in csv_dictreader
    for row in csv.DictReader(iterable):
  File "/usr/lib/python2.7/csv.py", line 108, in next
    row = self.reader.next()
  File "/usr/local/lib/python2.7/dist-packages/flexget/plugins/list/imdb_list.py", line 74, in <genexpr>
    iterable = (l.encode('utf-8') for l in iterable)
  File "/usr/local/lib/python2.7/dist-packages/requests/models.py", line 783, in iter_lines
    for chunk in self.iter_content(chunk_size=chunk_size, decode_unicode=decode_unicode):
  File "/usr/local/lib/python2.7/dist-packages/requests/utils.py", line 440, in stream_decode_response_unicode
    for chunk in iterator:
  File "/usr/local/lib/python2.7/dist-packages/requests/models.py", line 746, in generate
    raise ConnectionError(e)
ConnectionError: HTTPConnectionPool(host='www.imdb.com', port=80): Read timed out.

Steps to reproduce:

  • Connection to imdb.com times out -> imdb_list crashes

Additional information:

  • FlexGet version: 2.13.5
  • Python version: 2.7.12
  • Installation method: pip
  • Using daemon (yes/no): yes
  • OS and version: Ubuntu somethingorother

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions