Skip to content

[imdb_list] Use DictReader and index into rows with header names#2096

Merged
cvium merged 1 commit intodevelopfrom
fix_imdb_list_for_real
Mar 7, 2018
Merged

[imdb_list] Use DictReader and index into rows with header names#2096
cvium merged 1 commit intodevelopfrom
fix_imdb_list_for_real

Conversation

@cvium
Copy link
Copy Markdown
Contributor

@cvium cvium commented Mar 7, 2018

Motivation for changes:

Indexing with magical values (ints) is prone to breakage and it suuuucks

Detailed changes:

  • Changed to DictReader

Addressed issues:

Copy link
Copy Markdown
Member

@liiight liiight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@cvium cvium merged commit 4165d8a into develop Mar 7, 2018
@cvium cvium deleted the fix_imdb_list_for_real branch March 7, 2018 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants