Add jinja2 templates to ftp_download and fix infinite loop bug.#2078
Merged
liiight merged 3 commits intoFlexget:developfrom Feb 12, 2018
Merged
Add jinja2 templates to ftp_download and fix infinite loop bug.#2078liiight merged 3 commits intoFlexget:developfrom
liiight merged 3 commits intoFlexget:developfrom
Conversation
added 2 commits
February 12, 2018 19:44
Also better error handling when ftp download does not succeed.
liiight
requested changes
Feb 12, 2018
| if not os.path.isdir(config['ftp_tmp_path']): | ||
| log.debug('creating base path: %s' % config['ftp_tmp_path']) | ||
| os.mkdir(config['ftp_tmp_path']) | ||
| to_path = pathscrub(entry.render(config['ftp_tmp_path'])) |
Member
There was a problem hiding this comment.
better to catch RenderError here
liiight
approved these changes
Feb 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
ftp_download is really not useful without the ability to use jinja2 templates.
Also made a quick fix for cases when we run into download problems and the download loop starts to loop forever.
Detailed changes: