[FIX] More web changes Newpct1#2054
Merged
liiight merged 3 commits intoFlexget:developfrom Jan 4, 2018
Merged
Conversation
Now Newpct1 and Newpct share torrent urlrewrite.
liiight
reviewed
Jan 3, 2018
flexget/plugins/sites/newpct.py
Outdated
| torrent_id_prog = re.compile("(?:parametros\s*=\s*\n?)\s*{\s*\n(?:\s*'\w+'\s*:.*\n)+\s*'(?:torrentID|id)" | ||
| "'\s*:\s*'(\d+)'") | ||
| torrent_ids = soup.findAll(text=torrent_id_prog) | ||
| if len(torrent_ids): |
flexget/plugins/sites/newpct.py
Outdated
|
|
||
| NEWPCT_TORRENT_FORMAT = 'http://www.newpct.com/torrents/{:0>6}.torrent' | ||
| NEWPCT1_TORRENT_FORMAT = 'http://www.newpct1.com/download/{}.torrent' | ||
| NEWPCT_TORRENT_FORMAT = 'http://www.newpct.com/torrents/{:0>6}.torrent' |
Member
There was a problem hiding this comment.
looks like there's an extra space there
cvium
reviewed
Jan 3, 2018
| torrent_id_prog = re.compile('function openTorrent.*\n.*\{.*(\n.*)+window\.location\.href =\s*\".*\/(\d+).*\";') | ||
| torrent_ids = soup.findAll(text=torrent_id_prog) | ||
| if len(torrent_ids): | ||
| log.debug('torrent ID not found, searching openTorrent script') |
Contributor
There was a problem hiding this comment.
This doesn't really make sense if torrent_ids is empty/none or maybe I'm misunderstanding what that log is referencing
Contributor
Author
There was a problem hiding this comment.
There are two attempts to find torrent id, first regexp with 'parametros', then regexp with opentorrent. The log is a reference to the first regexp failure. Should I remove the log?
This was referenced Jan 4, 2018
|
Sorry for noise closed topics. I didn't want to open new topics because I didn't want to overload the error issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now Newpct1 and Newpct share torrent urlrewrite.
Motivation for changes:
Changes in newpct1
Detailed changes: