Changes how root_folder_path option is setup#2046
Merged
liiight merged 1 commit intoFlexget:developfrom Dec 20, 2017
JourneyOver:sonarr_list_rfp
Merged
Changes how root_folder_path option is setup#2046liiight merged 1 commit intoFlexget:developfrom JourneyOver:sonarr_list_rfp
liiight merged 1 commit intoFlexget:developfrom
JourneyOver:sonarr_list_rfp
Conversation
~ Changes how root_folder_path config option is setup. Now uses string value instead of an integer. Defaults to using an integer if no value is passed in config. - Removed comments on old root_folder_path setup.
liiight
reviewed
Dec 20, 2017
| # takes root_folder_path ID from config and subtracts 1 from it due to how script is setup | ||
| # since users are passing actual ID it won't be confusing to users | ||
| show['rootFolderPath'] = rootfolder[self.config.get('root_folder_path') - 1]['path'] | ||
| show['rootFolderPath'] = self.config.get('root_folder_path', rootfolder[0]['path']) |
Member
There was a problem hiding this comment.
if the user supplies root_folder_path we should probably not query for rootfolder, no?
Contributor
Author
There was a problem hiding this comment.
explained in gitter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
None really lol
Detailed changes: