Add filmweb_watchlist input plugin by dolohow · Pull Request #2034 · Flexget/Flexget

dolohow · 2017-12-08T15:55:28Z

Motivation for changes:

I want to be able to use my filmweb watch list as an input for Flexget.

Requirements

pip install pyfilmweb==0.1.1.1

Config usage if relevant (new plugin or updated schema):

tasks:
  populate-movie-list:
    filmweb_watchlist:
      login: 'username/email'
      password: 'password'
      min_star: 5
    accept_all: yes

Log and/or tests output (preferably both):

2017-12-08 16:38 VERBOSE  filmweb_watchlist populate-movie-list Retrieving filmweb watch list for user: user
2017-12-08 16:38 VERBOSE  filmweb_watchlist populate-movie-list Logging as user
2017-12-08 16:38 VERBOSE  filmweb_watchlist populate-movie-list Filmweb list contains 385 items
2017-12-08 16:38 VERBOSE  details       populate-movie-list Produced 3 entries.
2017-12-08 16:38 VERBOSE  task          populate-movie-list ACCEPTED: `Movie #1 (2017)` by accept_all plugin
2017-12-08 16:38 VERBOSE  task          populate-movie-list ACCEPTED: `Movie #2 (2017)` by accept_all plugin
2017-12-08 16:38 VERBOSE  task          populate-movie-list ACCEPTED: `Movie #3 (2017)` by accept_all plugin
2017-12-08 16:38 VERBOSE  details       populate-movie-list Summary - Accepted: 3 (Rejected: 0 Undecided: 0 Failed: 0)

To Do:

Fix crash one some movies in Python2 due to bug in library that I am using: https://github.com/lopezloo/pyfilmweb/issues/2

cvium · 2017-12-08T16:26:53Z

flexget/plugins/input/filmweb_watchlist.py

Not a very good assumption. What if something changes and it's no longer sorted or sorted differently?

You are right. Fixed

dolohow · 2017-12-14T14:36:37Z

Any plans on merging?

dolohow · 2017-12-19T22:11:02Z

Is there anything I can do to make this go into develop? @cvium @liiight

liiight · 2017-12-19T22:25:40Z

flexget/plugins/input/filmweb_watchlist.py

This pattern is kinda weird. We have a DependencyError exception for scenarios like this one

liiight · 2017-12-19T22:26:27Z

flexget/plugins/input/filmweb_watchlist.py

No need to call str here

It doesn't work without str.

Did you test on both python 2 and 3? If it expects bytes it need to be handled differently

It works in Python 3 without str. What should I do then?

Please paste the error you get without it on python 2

2017-12-21 13:27 CRITICAL plugin populate-movie-list Authentication request failed, reason (20, u'Incorrect JSON format')

addfrom builtins import *
and then readd the str.

Does this work correctly for both cases?

I added this line

from builtins import * # noqa pylint: disable=unused-import, redefined-builtin

and left this line

fw.login(str(config['login']), str(config['password']))

untouched

Works both python 2 and 3.

Is this what you wanted to me to change?

liiight · 2018-01-04T13:14:22Z

flexget/plugins/input/filmweb_watchlist.py

Please put this import at the top, directly below __future__

liiight · 2018-01-04T15:33:49Z

Please resync from develop branch

dolohow · 2018-01-04T16:07:52Z

Done

liiight · 2018-01-04T16:31:47Z

Bah, can you please fix that codacy issue so everything will be green please? 😁

dolohow · 2018-01-05T09:15:48Z

I am using DependencyError now when detecting if pyfilmweb is installed. This pattern is used across many plugins and apparently Codacy ignores # noqa.

Not sure what I can do about that.

liiight · 2018-01-05T09:32:15Z

Nm, merged.
Wanna update the wiki?

dolohow · 2018-01-05T09:42:52Z

sure

cvium reviewed Dec 8, 2017

View reviewed changes

dolohow force-pushed the filmweb branch 2 times, most recently from 15252bd to 77ac065 Compare December 8, 2017 16:31

liiight reviewed Dec 19, 2017

View reviewed changes

dolohow force-pushed the filmweb branch from 77ac065 to ec44966 Compare January 4, 2018 13:12

liiight reviewed Jan 4, 2018

View reviewed changes

flexget/plugins/input/filmweb_watchlist.py Outdated

Copy link
Copy Markdown

Member

liiight Jan 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this import at the top, directly below __future__

dolohow force-pushed the filmweb branch from ec44966 to 1f9fcac Compare January 4, 2018 14:27

Add filmweb_watchlist input plugin

82143a2

dolohow force-pushed the filmweb branch from 1f9fcac to 82143a2 Compare January 4, 2018 16:07

liiight merged commit da45c5f into Flexget:develop Jan 5, 2018

Conversation

dolohow commented Dec 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation for changes:

Requirements

Config usage if relevant (new plugin or updated schema):

Log and/or tests output (preferably both):

To Do:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dolohow commented Dec 14, 2017

Uh oh!

dolohow commented Dec 19, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liiight commented Jan 4, 2018

Uh oh!

dolohow commented Jan 4, 2018

Uh oh!

liiight commented Jan 4, 2018

Uh oh!

dolohow commented Jan 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liiight commented Jan 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dolohow commented Jan 5, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dolohow commented Dec 8, 2017 •

edited

Loading

dolohow commented Jan 5, 2018 •

edited

Loading

liiight commented Jan 5, 2018 •

edited

Loading