Skip to content

Microsoft team notifier added#2004

Merged
liiight merged 2 commits intoFlexget:developfrom
Jeremiad:develop
Nov 8, 2017
Merged

Microsoft team notifier added#2004
liiight merged 2 commits intoFlexget:developfrom
Jeremiad:develop

Conversation

@Jeremiad
Copy link
Copy Markdown
Contributor

@Jeremiad Jeremiad commented Nov 7, 2017 •
edited
Loading

Motivation for changes:

Added support for sending notifications to Microsoft Teams

Detailed changes:

Addressed issues:

  • Fixes # .

Implemented feature requests:

  • Feathub #XX.

Config usage if relevant (new plugin or updated schema):

    notify:
      entries:
        via:
          - microsoftteams:
              web_hook_url: http://example.com
              title: 'Flexget'

Log and/or tests output (preferably both):

paste output here

To Do:

  • Stuff..

liiight
liiight requested changes Nov 7, 2017
View reviewed changes
flexget/plugins/notifiers/microsoftteams.py Outdated

requests = RequestSession(max_retries=3)

__name__ = 'microsoftteams'
Copy link
Copy Markdown
Member

@liiight liiight Nov 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's kind of a mouthful. Maybe just teams? ms_teams maybe?

flexget/plugins/notifiers/microsoftteams.py Outdated
'web_hook_url': {'type': 'string'},
'message': {'type': 'string'},
'title': {'type': 'string'},
'themecolor': {'type': 'string'},
Copy link
Copy Markdown
Member

@liiight liiight Nov 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to theme_color

flexget/plugins/notifiers/microsoftteams.py Outdated
'type': 'object',
'properties': {
'web_hook_url': {'type': 'string'},
'message': {'type': 'string'},
Copy link
Copy Markdown
Member

@liiight liiight Nov 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

message should not be passed as part of the schema. It's passed via the notifiers interface directly

@Jeremiad
Copy link
Copy Markdown
Contributor Author

Jeremiad commented Nov 8, 2017

Should be better now.

@liiight liiight merged commit 1dd469c into Flexget:develop Nov 8, 2017
@liiight
Copy link
Copy Markdown
Member

liiight commented Nov 8, 2017

Thanks! Care to update the wiki?

@Jeremiad
Copy link
Copy Markdown
Contributor Author

Jeremiad commented Nov 9, 2017

Wiki updated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liiight liiight liiight requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jeremiad @liiight