Additional options for adding Sonarr series#1969
Merged
liiight merged 2 commits intoFlexget:developfrom Sep 24, 2017
Merged
Conversation
liiight
requested changes
Sep 24, 2017
flexget/plugins/list/sonarr_list.py
Outdated
| 'only_monitored': {'type': 'boolean', 'default': True}, | ||
| 'include_data': {'type': 'boolean', 'default': False} | ||
| 'include_data': {'type': 'boolean', 'default': False}, | ||
| 'searchForMissingEpisodes': {'type': 'boolean', 'default': True}, |
Member
There was a problem hiding this comment.
I know you wanted to stay true with the original Sonarr API name, but we use camel case where relevant. Please switch to that.
Contributor
Author
There was a problem hiding this comment.
Is it good names?
'search_missing_episodes':
'ignore_episodes_without_files'
'ignore_episodes_with_files'
Member
There was a problem hiding this comment.
kinda long but i dont have any better ideas
liiight
approved these changes
Sep 24, 2017
Member
|
thanks! care to update the wiki? |
Contributor
Author
|
Sure. I have updated wiki. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Where are no options to add series to Sonarr in unmonitored state.
Sonarr starts searching episodes right after adding.
It's not always good especially if series consist of many seasons.
Detailed changes:
addOptionsto Sonarr POST data.Documentation link
New options have defaults and not affected users configs.
Config usage if relevant (new plugin or updated schema):
Log and/or tests output (preferably both):
To Do: