Series specials are detected as season packs #1900
Description
Expected behaviour:
when 'Specials: yes' is enabled, "Special" episodes should be accepted by Series plugin despite season pack settings
- suggestion: season pack detection should be skipped when Series plugin marks series_id_type = u'special'
Actual behaviour:
Specials are detected as season_pack=True and Rejected if "season pack support is turned off" even if Specials: yes is enabled
Steps to reproduce:
- Step 1: ...
example config to test and reproduce below. For example purposes this just needs to scan a filesystem with content, exec will write a file with all the rejected files. (notably the specials) When run it -L trace it shows all the "specials" also get marked as "season_packs"
Config:
tasks:
test:
filesystem:
path: /media/tv/Doctor Who 2005/
recursive: true
retrieve: files
all_series: yes
exec:
on_output:
for_rejected: echo "{{location}}" >> /tmp/testfile-reject
Log:
2017-07-24 17:02 DEBUG parser_internal test Parsing series: `Doctor.Who.2005.S04.Christmas.Special.The.Next.Doctor.WS.PDTV.XviD-CaRaT` kwargs: {'identified_by': u'auto', 'name': None, 'allow_seasonless': False}
2017-07-24 17:02 DEBUG parser_internal test Parsing result: <SeriesParser(data=Doctor.Who.2005.S04.Christmas.Special.The.Next.Doctor.WS.PDTV.XviD-CaRaT,name=Doctor Who 2005,id=s04 christmas the next doctor ws carat,season=4,season_pack=True,episode=None,quality=sdtv xvid,proper=0,status=OK)> (in 0.652 ms)
2017-07-24 17:02 TRACE entry test ENTRY SET: series_parser = <flexget.utils.titles.series.SeriesParser object at 0x7fdb591e7f90>
2017-07-24 17:02 TRACE entry test ENTRY SET: series_name = u'Doctor Who 2005'
2017-07-24 17:02 TRACE entry test ENTRY SET: quality = <Quality(resolution=unknown,source=sdtv,codec=xvid,audio=unknown)>
2017-07-24 17:02 TRACE metainfo_quality test Found quality sdtv xvid for Doctor.Who.2005.S04.Christmas.Special.The.Next.Doctor.WS.PDTV.XviD-CaRaT
2017-07-24 17:02 TRACE entry test ENTRY SET: quality = <Quality(resolution=unknown,source=sdtv,codec=xvid,audio=unknown)>
2017-07-24 17:02 TRACE entry test ENTRY SET: proper = False
2017-07-24 17:02 TRACE entry test ENTRY SET: proper_count = 0
2017-07-24 17:02 TRACE entry test ENTRY SET: release_group = None
2017-07-24 17:02 TRACE entry test ENTRY SET: season_pack = True
2017-07-24 17:02 TRACE entry test ENTRY SET: series_season = 2017
2017-07-24 17:02 TRACE entry test ENTRY SET: series_episodes = 1
2017-07-24 17:02 TRACE entry test ENTRY SET: series_id = u's04 christmas the next doctor ws carat'
2017-07-24 17:02 TRACE entry test ENTRY SET: series_id_type = u'special'
2017-07-24 17:02 TRACE entry test ENTRY SET: series_identified_by = u'ep'
2017-07-24 17:02 TRACE entry test ENTRY SET: series_exact = False
2017-07-24 17:02 TRACE entry test ENTRY SET: series_guessed = True
Additional information:
- FlexGet version: 2.10.72
- Python version: 2.7.13
- Installation method: pip
- Using daemon (yes/no): no (not in test config)
- OS and version: debian 9