Conversation
liiight
reviewed
Jul 24, 2017
| for entry in task.all_entries: | ||
| # if pattern matches any entry | ||
| if field not in entry: | ||
| log.debug('Field %s not found. Skipping.', field) |
| if field not in entry: | ||
| log.debug('Field %s not found. Skipping.', field) | ||
| if abort_re.search(entry[field]): | ||
| task.abort('An entry contained %s in field %s. Abort!' % (config['regexp'], field)) |
Member
There was a problem hiding this comment.
You can silently abort, bit sure if it fits here though
Contributor
Author
There was a problem hiding this comment.
Dunno. I kind of want logging but I also don't want to add a separate log entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
I wants it. When using LFTP or another program to download from a remote location, it can ruin a lot if FlexGet moves files before the transfer is completed. A lot of it can be handled by using "incomplete" filenames in LFTP, but there are situations where I want the transfer to be fully completed before moving.
Detailed changes: