[fix] Made sure ignores actually work#1889
Merged
cvium merged 2 commits intoFlexget:developfrom Jul 3, 2017
richardsimko:develop
Merged
[fix] Made sure ignores actually work#1889cvium merged 2 commits intoFlexget:developfrom richardsimko:develop
cvium merged 2 commits intoFlexget:developfrom
richardsimko:develop
Conversation
cvium
reviewed
Jul 3, 2017
flexget/plugins/daemon/irc.py
Outdated
Contributor
There was a problem hiding this comment.
Forgot to capitalize True and you should probably break as well
Contributor
Author
There was a problem hiding this comment.
Yep, just discovered this on my local instance! As mentioned I'm not a Python dev. Fix incoming
Contributor
Author
There was a problem hiding this comment.
Good point about the break, I'll add that!
cvium
reviewed
Jul 3, 2017
flexget/plugins/daemon/irc.py
Outdated
Member
|
Why not just use for-else? It's cleaner that way imo |
Contributor
|
How? You only reach the else-branch if the for-loop doesn't hit a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Ignoring lines in IRC currently does not work. A
continueonly skips the innermost loop ;)Detailed changes:
continueto a boolean and moved the skip to after the iteration over all ignored patternsAddressed issues:
N/A
Implemented feature requests:
N/A
Config usage if relevant (new plugin or updated schema):
None
Log and/or tests output (preferably both):
There doesn't seem to be any tests for the IRC plugin. I'm by no means a Python developer so I'm probably not the best person to create them. If I've missed them (Or if there's some other good place for me to add a test case for this) then feel free to point it out!
To Do:
None