Skip to content

Plugins/rss issue with cache (all_entries: no) and items without title #1885

@thawn

Description

@thawn

Expected behaviour:

the rss cache should work, even if there are items after an item with empty title.

Actual behaviour:

when there is an item with empty title that appears not at the very end of a feed, the cache does not work anymore

Steps to reproduce:

  • Step 1: in tests/rss.xml move an item that has a title towards the end of the file after the item that has no title (see this pastebin for the xml code that breaks the cache.
  • Step 2: run py.test tests/test_rss.py
    the test: TestInputRSS.test_all_entries_no will fail because it finds entries also in the second run. See
    this pastebin for the log output of the test (note that the first run produced 9 entries, the second run produced 7 entries).
  • Step 3: revert back to the original tests/rss.xml
  • Step 2: run py.test tests/test_rss.py
    the test: TestInputRSS.test_all_entries_no will be successful.

Config:

no changes to test configuration

Log:

https://pastebin.com/L5J0nQJ0

Additional information:

  • FlexGet version: git develop branch commit b466d7b
  • Python version: affects all versions (on Travis CI)
  • Installation method: github
  • Using daemon (yes/no): no
  • OS and version: mac os X (but also affects linux on Travis CI)
  • Link to crash log: none generated

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions