Conversation
cvium
reviewed
Jun 3, 2017
|
|
||
| @property | ||
| def name(self): | ||
| """Return name of the torrent""" |
Contributor
Author
There was a problem hiding this comment.
Because I was copying from private. It should be an empty string.
cvium
reviewed
Jun 3, 2017
|
|
||
| @property | ||
| def name(self): | ||
| """Return name of the torrent""" |
Contributor
There was a problem hiding this comment.
My point was rather, why return something specific at all? get will return None if the key isn't set. But maybe an empty string will be better for jinja etc. Dunno.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
The
nameattribute of theinfodictionary in the torrent file is often used as the container folder name in various torrent programs. However, this is not exposed in FlexGet.Detailed changes:
nameis now a property of theTorrentclass and returns thenameattribute of theinfodictionary from the torrent file.