Conversation
…ated dev_tools.py and __init__.py based on new webui
|
Well I already see what you meant by react being more understandable than angular... |
|
Yeah that makes sense. I'll make the change. |
dev_tools.py
Outdated
| # Install bower packages | ||
| click.echo('running `bower install`') | ||
| subprocess.check_call('bower install -p', cwd=cwd, shell=True) | ||
| subprocess.check_call('bower install', cwd=cwd, shell=True) |
There was a problem hiding this comment.
@kristenmills Maybe we should switch to Yarn? bower/bower#2298
There was a problem hiding this comment.
Bower was used on the old ui not the new one. We're using npm 5 on the new one.
|
Hey @kristenmills i'm having a look at this. Can you help me understand the layout of the folders etc? Also the snapshots folders? |
|
Sounds good to me |
flexget/api/app.py
Outdated
| from . import __path__ | ||
|
|
||
| __version__ = '1.3.0' | ||
| __version__ = '1.4.0' |
There was a problem hiding this comment.
For non breaking api changes we usually just bump patch. No biggie though
flexget/plugins/daemon/web_server.py
Outdated
| 'ssl_private_key': {'type': 'string'}, | ||
| 'web_ui': {'type': 'boolean'}, | ||
| 'base_url': {'type': 'string'}, | ||
| 'version': {'type': 'integer', |
There was a problem hiding this comment.
I think that it'd be better to have an ability to run both uis simultaneously
|
yeah merge it in i'd say.. assuming v1 still works fine? I've been learning reactjs-redux and am already ready to start work on this also. |
|
I think that until v1 can be completely deprecated, v2 should be able to run along side it and not replace it |
|
v2 is not ready to take the place of v1 just yet. Just saying we need to keep v1 as default for now. |
|
Yeah it's set up so that v1 is the default. I'm working right now to configure v2 to run along aside. |
|
Now the v1 ui runs at root. if you add |
|
Good enough for now but ideally I think having a list key will be nicer: web_ui:
- v1
- v2 |
|
agree, run side by side.. |
|
Yeah key listing is probably better. I'll do that after work today. |
Starting a WIP pull request for better visibility.
Motivation for changes
Nobody wants to write Angular 1. Now they don't have to! 💯
Detailed changes:
To Do:
https://github.com/Flexget/Flexget/projects/4
Wiki
https://flexget.com/Web-UI/v2