Skip to content

[add] parser - Support for DD+ audio and more channels#1842

Merged
cvium merged 7 commits intodevelopfrom
ddplus
Jun 5, 2017
Merged

[add] parser - Support for DD+ audio and more channels#1842
cvium merged 7 commits intodevelopfrom
ddplus

Conversation

@cvium
Copy link
Copy Markdown
Contributor

@cvium cvium commented May 25, 2017

Motivation for changes:

DD+ audio is becoming more common. It stands for Dolby Digital Plus aka Enhanced AC-3 and it is therefore better than both DD and AC-3. It supports up to 7.1 channels and a more efficient compression.

Detailed changes:

  • Added dd+/ddp to qualities.py
  • Added tests for series and quality filter
  • Added support for parsing x.{0,1} audio eg. 7.1, 5.0 etc.

@cvium cvium changed the title Added support for dd+ audio Added support for dd+ audio and more channels May 25, 2017

@pytest.fixture()
def config(self):
"""Overrides outer config fixture since season pack support does not work with guessit parser"""
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Season_pack

@tubedogg tubedogg changed the title Added support for dd+ audio and more channels [add] parser - Support for DD+ audio and more channels May 26, 2017


class TestQualityInternalParser(object):
@pytest.mark.parametrize("test_quality", [
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can set it a two vars instead of one that'll create a tuple, might be a little easier to read imo

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just following the same format as the other tests.

@cvium cvium merged commit 8791820 into develop Jun 5, 2017
@cvium cvium deleted the ddplus branch June 5, 2017 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants