Conversation
The `deluge` option `label` is now rendered by Jinja.
liiight
reviewed
May 24, 2017
| label = format_label(entry.render(entry.get('label', config.get('label')))) | ||
| log.debug('Rendered label: %s', label) | ||
| except RenderError as e: | ||
| log.error('Error rendering label `%s`: %s', label, e) |
Member
There was a problem hiding this comment.
If you'll get a render error, won't label be undefined?
Contributor
Author
There was a problem hiding this comment.
Yes but if the render fails, except will cause it to continue to the next entry before it gets to using label.
Contributor
Author
|
Any thoughts on this one? |
Member
|
i dont use deluge or have anything to do with the plugin so im hesitant to merge. |
cvium
approved these changes
Jun 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Yet another step towards me not needing a custom
delugeplugin anymore. (Also it's a feature request.)Detailed changes:
The
delugeoptionlabelis now a jinja-rendered field.Implemented feature requests: