Conversation
|
Incorrect sort for Also is this supposed to be reverse chronological or forward chronological? Another show I have is sorted (I thought) correctly, in that it shows S06E01, then S05, then S04, on down to S01, in that order. CLI |
|
The main sort is correct (age), ill add a secondary sort by name |
|
Look at the second block again. Sorting by age, how does S06E16 end up on top? |
|
hmm, you're right, sorry |
ce97473 to
23f502e
Compare
|
@tubedogg you feel like retesting this? |
|
Yeah I will tonight.
…On April 30, 2017 at 9:42:23 AM, Or Carmi ***@***.***) wrote:
@tubedogg <https://github.com/tubedogg> you feel like retesting this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1797 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGKv1ao71Rvc3s_jGkXiI6lln9qXkPYGks5r1J3PgaJpZM4NAjO1>
.
|
|
I think i messes up the new logic with |
|
Looking at my prior comments with sorting, Once Upon a Time is now sorted correctly. Review is now correct with just the season packs, but I tried throwing in a random episode to see what would happen, and it ended up on top, which I don't think it should be (though I realize that is the correct behavior based on how it's currently programmed). I didn't totally realize you said sorting by age last time. I don't think that makes sense, or at least it shouldn't be the default. I think the default should be by entity ID. I'm also not sure about reverse sort. I would think generally you're going to be looking for what's newest (if sorting by age) or highest (if sorting by entity ID). For a show with a lot of stuff seen, that's going to be buried a screen or two or five back in the terminal when sorting in the reverse order. I also tried sorting with a show I thought I had individual episodes from more than one season (no season packs). It crashed. I believe this is because this particular show has a I'll hold off on testing the |
|
I gave it a shot anyway. Results were as expected except for one case. Without backfill enabled: Download history of season pack S02 and episode S03E01, series_begin set to S02E01: emits S03/S03E02 as expected. After enabling backfill: Download history of season pack S02 and episode S03E01: emits S03 and S01/S03E02 and S01E01 as expected. Download history of season pack S02 and episode S03E01, series_begin set to S02E01: |
|
Thanks for the input, that's great stuff. I'll fix the None issue with the sorting, good catch. About next series plugins, I'll look into, need to be more concentrated. |
|
I pushed some stuff, give it another look please
hmm, why would it even emit s03e01 it that was already downloaded? can you paste config and logs for that one please? |
|
Figured it out. During review of season 2, Add this above line 140 to fix it: |
|
It's an interesting theory but when season is compared to ep it only compares season number: Need to debug that scenario |
|
Ok I actually figured it out this time. Season 2 is completed (so it was being skipped anyway) BUT it just continues to the next season in that case. Meaning during season 2, it never gets down to line 188 to break (which it would, because 2 >= 2), and fully processes season 1 (which in turn is bumped to season 2 and then 3 by that first conditional block). And then it downloads it anyway because there's no check for downloaded episodes in a future season. I don't know if that scenario can happen if it was correctly breaking, but I feel like the download check can't hurt at that point. |
|
I think that block can go on top. There's no need to continue the loop if season is higher than begin.season, no? |
|
If you're moving it to the top the check should be if season is lower than begin.season, otherwise it won't process the begin season before breaking. |
The tests involving series.begin will still fail until that issue is resolved in the actual plugins in a separate commit.
|
I'm moving the conditional block we were talking about so the rest of the tests stop failing (now that I fixed my stupid mistakes). If we want to also check for a prior download like I suggested that can be added later. |
Resolves an issue where a season prior to series.begin could be processed before the break check is reached
- low_season has to be 1 lower than the actual last season to test for range() to work correctly - Only try to check if begin season is completed while evaluating the begin season (otherwise, with gaps in history, it will only ever emit the begin episode)
- Gaps between season packs - from_start enabled
- low_season has to be 1 lower than the actual last season to test for range() to work correctly - Only try to check if begin season is completed while evaluating the begin season (otherwise, with gaps in history, it will only ever emit the begin episode)
- Gaps between season packs - from_start enabled
|
The ordering is still an issue. On latest master (version 2.10.47), shows are mostly in reverse chrono, which completely breaks usability from before (if it scrolls off screen, you have to pipe through a pager, and then that changes output to porcelain). And many shows history are randomly ordered. The last version which this isn't an issue for me is d03b686 |
That is how it is coded to work, yes. Whether it should be or not is another discussion.
I don't necessarily disagree on this point, see my earlier comments in this thread. If you feel strongly about this I'd suggest opening an feature request - since it's working as intended, it's not a bug.
Please open an issue and provide examples. This is a bug if this is still occurring. Note that ordering is reverse chronologically by order of date the entry containing that entity was accepted, not by release date or anything else. So if you obtained episodes/seasons out of order, they will be out of order in terms of entity ID, but still correctly displayed based on how it is currently designed to display. The option to sort by entity ID is something I would like to get added at some point. |
|
No need to open an issue on order, that is a mistake on my part. Like @tubedogg said, open an issue on the random part |
Motivation for changes:
More stuff to do
Detailed changes:
forgetCLIseries forget foo s01 s02e01 s03e01series shownext_series_Xdidn't emit the next entity if the last one was a season pack with not series begin set.series showsort bugnext_series_Xemitted the begin episode in error if there was a gap in series history