Preparing for no files key when magnetizing#1752
Merged
liiight merged 1 commit intoFlexget:developfrom Mar 24, 2017
Merged
Conversation
liiight
reviewed
Mar 24, 2017
Member
liiight
left a comment
There was a problem hiding this comment.
Looks like you could just do
If status.get('files'):
Contributor
Author
|
Sure why not |
Now prepared for the fact that `status` may not contain `files` before magnetization also a bit more Pythonic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Detailed changes:
[]when trying to accessstatus['files'], which might not exist.Addressed issues:
This is the error I had.
TODO
Line can also be:
I have no strong opinion in either way.