[fix] divxatope to use new domain divxatope1#1655
Merged
cvium merged 4 commits intoFlexget:developfrom Feb 10, 2017
Merged
Conversation
New domain divxatope1 instead of divxatope. Updated urlrewrite and search.
cvium
reviewed
Jan 25, 2017
flexget/plugins/sites/divxatope.py
Outdated
| return ( | ||
| url.startswith('http://www.divxatope.com/descargar') or url.startswith('http://divxatope.com/descargar') | ||
| ) | ||
| rewritable_regex = '^http:\/\/(www.)?divxatope1?.com.*' |
Contributor
Author
There was a problem hiding this comment.
Their certificate is expired, but I will add the "https?" with the other changes.
cvium
reviewed
Jan 25, 2017
flexget/plugins/sites/divxatope.py
Outdated
| if quality_lan is None: | ||
| continue | ||
| quality_lan = quality_lan.contents | ||
| #log.debug(len(quality_lan)) |
cvium
reviewed
Jan 25, 2017
flexget/plugins/sites/divxatope.py
Outdated
| query = normalize_unicode(search_string) | ||
| query = regex.findall(query)[0] | ||
| if regex.findall(query): | ||
| query = regex.findall(query)[0] |
Contributor
There was a problem hiding this comment.
is findall necessary if you're just grabbing the first one anyway?
Contributor
Author
There was a problem hiding this comment.
What should I use instead?
Contributor
Author
There was a problem hiding this comment.
This?
if regex.search(query) is not None:
query = regex.search(query).group(1)
cvium
reviewed
Jan 25, 2017
flexget/plugins/sites/divxatope.py
Outdated
| log.debug('Searching DivxATope %s' % query) | ||
| query = query.encode('utf8', 'ignore') | ||
| data = {'search': query} | ||
| #data = {'search': query} |
Removed unnecessary comments Year removed with sub
cvium
reviewed
Jan 26, 2017
flexget/plugins/sites/divxatope.py
Outdated
| def url_rewrite(self, task, entry): | ||
| # Rewrite divxatope.com/descargar/ to divxatope.com/descarga-torrent/ | ||
| entry['url'] = re.sub('/descargar', '/descarga-torrent', entry['url']) | ||
| entry['url'] = re.sub("/descargar/", "/descarga-torrent/", entry['url']) |
Contributor
There was a problem hiding this comment.
I don't like this change. All other strings in this plugin use single quotes.
cvium
reviewed
Jan 26, 2017
flexget/plugins/sites/divxatope.py
Outdated
| return set() | ||
| log.debug('Search DivxATope') | ||
| url_search = 'http://www.divxatope.com/buscar/descargas/' | ||
| #url_search = 'http://www.divxatope.com/buscar/descargas/' |
Contributor
There was a problem hiding this comment.
You can just remove this. If we need the old URL it's available in Git history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New domain divxatope1 instead of divxatope. Updated urlrewrite and search.
Motivation for changes:
divxatope redirected to divxatope1
Detailed changes:
Addressed issues:
Config usage if relevant (new plugin or updated schema):
Log and/or tests output (preferably both):
Search example