Skip to content

Python 3.6 compatibility#1632

Merged
liiight merged 7 commits intodevelopfrom
py36
Nov 19, 2017
Merged

Python 3.6 compatibility#1632
liiight merged 7 commits intodevelopfrom
py36

Conversation

@liiight
Copy link
Copy Markdown
Member

@liiight liiight commented Jan 16, 2017

Motivation for changes:

Add support for python 3.6

Detailed changes:

  • Added to .travis.yml
  • Added to CircleCI
  • Added explicit commit after adding a new column due to change in python API in 3.6: sqlite3 no longer implicitly commits an open transaction before DDL statements.

@liiight liiight mentioned this pull request Jan 16, 2017
@cvium cvium changed the title Python 3.6 compatability Python 3.6 compatibility Jan 23, 2017
session.execute('VACUUM')
except OperationalError as e:
# Does not work on python 3.6, github issue #1596
log.error('Could not execute VACUUM command: %s', e.args[0])
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why e.args?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

force of habit, ill just pass to logger then

@liiight liiight merged commit d3d8e17 into develop Nov 19, 2017
@liiight liiight deleted the py36 branch November 19, 2017 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants