Merged
Conversation
8eeba82 to
585bedb
Compare
Member
|
I hope using dropdown is not needed when adding movie. By default it should go to default list without any additional selection. |
Contributor
Author
|
No indeed, I'm planning on using the currently selected movie list as default for the dropdowns. |
Member
|
What is a default list? That exists only in the CLI scope. Should that be configured in UI side? |
…es to, adding movie works as well
…results as well as loading animation
2711f4e to
ec3db8d
Compare
…he bottom of the tab-toolbar
…t stuff regarding tabs width
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
This PR allows users to add a movie to any existing movie_list from the web UI.
Detailed changes:
Movies section of the UI has a new input field, allowing users to type a movie name (maybe later imdb/trakt/... ids?). This name will be searched for on the API using several different providers.
Add button only enabled after list is selected
Scrollable content
Addressed issues:
No fix, just addition
Log and/or tests output (preferably both):
Test are still left to do
TODO: