Skip to content

FTP input plugin improvement suggestions #1162

@Meliox

Description

@Meliox

Findings and suggestions after testing #1161
as discussed with @liiight

Test config:

tasks:
  ftpauto:
    ftp_list:
      username: user
      password: 'a password'
      host: someip
      port: someport
      retrieve: dirs
      use_ssl: yes
      dirs: ./test/
      regex: pal
    series:
      - Girls
    download: C:\Users\Administrator\Desktop\autodl\complete
  1. Plugin iterates over everything, making it slow to progress 1000 directories.
    http://pastebin.com/gg7mPisy

Using the following in dirs property returns above.
./test/
/test/
test

  1. Doesn't check/validate valid/invalid properties

  2. Suggest adding a recursion flag to define how many subdirectories should be processed

  3. When using dirs, it should only look into the directories defined in config.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions