Remove mongo: point daemon to use fork of textile#266
Merged
Conversation
Contributor
|
This looks like huge amount of work that you've done: textileio/textile@master...FleekHQ:feature/use-badger-for-local Well done 🙌 |
studna
approved these changes
Nov 27, 2020
maurycy
approved these changes
Nov 27, 2020
Contributor
maurycy
left a comment
There was a problem hiding this comment.
Great job!
Do we plan on updating the README.md?
README.md
79:### MongoDB
81:Currently, local Textile Threads require a running MongoDB database. Space Daemon by default connects to a hosted one, but this will be removed once Textile switches over to an embeddable data store.
89:MONGO_PW=[The password of a MongoDB database]
90:MONGO_USR=[The user of a MongoDB database]
91:MONGO_HOST=[The host of a MongoDB database]
92:MONGO_REPLICA_SET=[The replica set for a MongoDB database]
191:Stage specific secret names will only be used for secrets `release.yml` that point to the step output instead of the secret name directly (i.e., `SERVICES_API_URL: ${{ secrets[steps.secretnames.outputs.SERVICES_API_URL] }}` instead of `MONGO_REPLICA_SET: ${{ secrets.MONGO_REPLICA_SET }}`.
perfectmak
approved these changes
Nov 27, 2020
Contributor
perfectmak
left a comment
There was a problem hiding this comment.
This is a really welcome change 😀... Also, would be one less dependency on the integration test setup.
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log