Hotfix: add type for recover, and some cleanups#260
Merged
Conversation
perfectmak
suggested changes
Nov 20, 2020
Contributor
perfectmak
left a comment
There was a problem hiding this comment.
Generally looks good. I requested a change that you missed in the proto defintions.
| message RecoverKeysByPassphraseRequest { | ||
| string uuid = 1; | ||
| string passphrase = 2; | ||
| KeyBackupType type = 3; |
Contributor
There was a problem hiding this comment.
You should also update the enum KeyBackupType definition of the proto file to contain the new fields
perfectmak
approved these changes
Nov 20, 2020
Contributor
perfectmak
left a comment
There was a problem hiding this comment.
LGTM. There are some conflicts though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the
typefield to the recover method and also updated the enum to be Google, Twitter, etc instead of Eth.