feat(json-beautifier): allow single quote around values#24
Merged
martindrapeau merged 2 commits intoFlatFilers:masterfrom Oct 8, 2017
Merged
feat(json-beautifier): allow single quote around values#24martindrapeau merged 2 commits intoFlatFilers:masterfrom
martindrapeau merged 2 commits intoFlatFilers:masterfrom
Conversation
This commit allows the user to select whether to allow single quote or double quote around values FlatFilers#23
js/csvjson/json_beautifier.js
Outdated
| @@ -75,11 +75,12 @@ | |||
| dropQuotesOnNumbers = options.dropQuotesOnNumbers || false, | |||
| inlineShortArrays = options.inlineShortArrays || false, | |||
| inlineShortArraysDepth = options.inlineShortArraysDepth || 1; | |||
Collaborator
There was a problem hiding this comment.
Semicolon and comma.
inlineShortArraysDepth = options.inlineShortArraysDepth || 1,
quoteType = options.quoteType || 'double';
| <label class="inline" title="Quote type around values"> | ||
| Quotes | ||
| <select id="quote-type" name="quote-type" class="save"> | ||
| <option value="single">Single Quote</option> |
Collaborator
There was a problem hiding this comment.
Simply use Single and Double for the option text - shorter.
Collaborator
|
I tested it works nicely. Two small tweaks to make then I will merge your PR. Good job! |
Contributor
Author
|
Thanks for your review @martindrapeau Update the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the user to select whether to allow single quote or double quote around values
fixes #23