Skip to content

fix: Revert "Fixes missing HTTP header X-Goog-User-Project"#2352

Merged
adamvduke merged 1 commit into
masterfrom
revert-2348-vinaypotluri/missing-X-Goog-User-Project-2347
Mar 10, 2023
Merged

fix: Revert "Fixes missing HTTP header X-Goog-User-Project"#2352
adamvduke merged 1 commit into
masterfrom
revert-2348-vinaypotluri/missing-X-Goog-User-Project-2347

Conversation

@adamvduke

Copy link
Copy Markdown
Contributor

Reverts #2348

Unfortunately, this has unintended consequences for authorization with service accounts. Reverting/releasing a new version to limit the spread of the versions containing this change.

@adamvduke adamvduke changed the title Revert "Fixes missing HTTP header X-Goog-User-Project" fix: Revert "Fixes missing HTTP header X-Goog-User-Project" Mar 10, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Timestamp: 2023-03-10 19:20:31
Buildscan url for ubuntu-workflow run 4387693761

@adamvduke adamvduke requested a review from schnecle March 10, 2023 19:25

@schnecle schnecle left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamvduke adamvduke merged commit bcbc82a into master Mar 10, 2023
@adamvduke adamvduke deleted the revert-2348-vinaypotluri/missing-X-Goog-User-Project-2347 branch March 10, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants