Fix benchmark projects failing at runtime#644
Merged
ewoutkramer merged 2 commits intodevelopfrom Mar 11, 2026
Merged
Conversation
ewoutkramer
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how package versions are handled in benchmark configuration, moving from single-version to dual-version (Validator and SDK) support. The changes improve flexibility and clarity by explicitly specifying both
ValidatorVersionandSDKVersionfor each benchmark run, and updating the project file to use these properties for package references.Benchmark configuration improvements:
PackageVersionandPackageVersionAttributeto include bothValidatorVersionandSDKVersion, allowing benchmarks to target specific combinations of validator and SDK versions. [1] [2]CrossVersionConfigurationAttributeto use the new dual-version structure, ensuring correct version selection and job creation for benchmarks. [1] [2]Project file changes for version flexibility:
Benchmarks.csprojto useValidatorVersionandSDKVersionproperties for package references, enabling dynamic selection of package versions based on defined constants.Benchmark annotation updates:
ValidatorBenchmarksto use the newPackageVersionAttributeformat, specifying both validator and SDK versions for each benchmark case.