Skip to content

Fix benchmark projects failing at runtime#644

Merged
ewoutkramer merged 2 commits intodevelopfrom
fix/benchmark-project-runtime-errors
Mar 11, 2026
Merged

Fix benchmark projects failing at runtime#644
ewoutkramer merged 2 commits intodevelopfrom
fix/benchmark-project-runtime-errors

Conversation

@andrzejskowronski
Copy link
Copy Markdown
Contributor

This pull request refactors how package versions are handled in benchmark configuration, moving from single-version to dual-version (Validator and SDK) support. The changes improve flexibility and clarity by explicitly specifying both ValidatorVersion and SDKVersion for each benchmark run, and updating the project file to use these properties for package references.

Benchmark configuration improvements:

  • Changed PackageVersion and PackageVersionAttribute to include both ValidatorVersion and SDKVersion, allowing benchmarks to target specific combinations of validator and SDK versions. [1] [2]
  • Updated the logic in CrossVersionConfigurationAttribute to use the new dual-version structure, ensuring correct version selection and job creation for benchmarks. [1] [2]

Project file changes for version flexibility:

  • Refactored Benchmarks.csproj to use ValidatorVersion and SDKVersion properties for package references, enabling dynamic selection of package versions based on defined constants.

Benchmark annotation updates:

  • Updated ValidatorBenchmarks to use the new PackageVersionAttribute format, specifying both validator and SDK versions for each benchmark case.

@ewoutkramer ewoutkramer merged commit fbf54b1 into develop Mar 11, 2026
2 checks passed
@ewoutkramer ewoutkramer deleted the fix/benchmark-project-runtime-errors branch March 11, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants