Merged
Conversation
ewoutkramer
requested changes
Mar 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
test/Firely.Fhir.Validation.Compilation.Tests.Shared/SimpleValidationsTests.cs
Outdated
Show resolved
Hide resolved
test/Firely.Fhir.Validation.Compilation.Tests.Shared/BasicSchemaBuilderTests.cs
Outdated
Show resolved
Hide resolved
test/Firely.Fhir.Validation.Compilation.Tests.Shared/SimpleValidationsTests.cs
Outdated
Show resolved
Hide resolved
test/Firely.Fhir.Validation.Compilation.Tests.Shared/TestProfileArtifactSource.cs
Outdated
Show resolved
Hide resolved
…leArtifactSource.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…maBuilderTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…idationsTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ewoutkramer
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem with checking slices of a primitive type (string, in this case). These slices carry a cardinality for the value, which is applied to the collection because there is no hierarchical difference between collection and value. The solution is to actively remove the cardinality check for value. That is not a problem, since it is already 1..1 bound to the item